Open
Conversation
Closed
ksss
reviewed
Mar 9, 2026
ksss
left a comment
ksss
left a comment
There was a problem hiding this comment.
The test code differs significantly from the ruby/rbs version, making it difficult to pinpoint the differences.
Can it be made as close to the original as possible?
If there are issues with the original, please let me know.
| - name: Set up Ruby | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: "4.0" |
There was a problem hiding this comment.
Suggested change
| ruby-version: "4.0" | |
| ruby-version: ruby |
| t.libs << "test_sig" | ||
| t.ruby_opts << "-rtest_helper" | ||
| t.test_files = FileList["test_sig/test_*.rb"] | ||
| end |
There was a problem hiding this comment.
An rbs:annotate command would be convenient for maintenance.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #278 for context.